-
Notifications
You must be signed in to change notification settings - Fork 371
feat(payments): add UPI Collect support and core payment sync #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @g-divyanshu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the agent payments protocol sample by integrating UPI Collect payment functionality. It establishes a new mock bank server to simulate UPI transactions and their lifecycle, from initiation to approval. The changes also involve updating various agent roles to seamlessly handle UPI Collect payments, including managing multi-channel authentication challenges and implementing asynchronous payment status polling. This allows for a complete demonstration of UPI Collect payments in a human-present commerce flow. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for UPI Collect payments and a core payment synchronization mechanism. The changes are comprehensive, including a new mock bank server, extensive documentation, and updates across multiple agents to handle the asynchronous UPI payment flow. My review focuses on improving documentation consistency, adhering to code style best practices, and fixing a critical import error. Overall, this is a well-executed feature with a high level of detail in both implementation and documentation.
samples/python/src/roles/merchant_payment_processor_agent/tools.py
Outdated
Show resolved
Hide resolved
| "currency": "INR", | ||
| "description": "Optional" | ||
| }, | ||
| "customer_data": { // Optional section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment // Optional section uses a C-style comment format within a Python docstring. While this doesn't break anything, the standard comment character in Python is #. For consistency with Python's style, it's better to use #. This also applies to the comment on line 48.
| "customer_data": { // Optional section | |
| "customer_data": { # Optional section |
samples/python/scenarios/a2a/human-present/upi_collect/README.md
Outdated
Show resolved
Hide resolved
86b8769 to
93786ef
Compare
Summary
Add UPI Collect as a supported payment method in A2A human-in-the-loop
scenarios. UPI is a widely used real-time payment system in India. Introduces
a mock bank server to simulate MCA flows and enables async payment completion
via status polling.
Changes (by role)
Mock Bank
Merchant Agent
Shopping Agent
Merchant Payment Processor Agent
Credentials Provider Agent
Scenarios & Docs
Behavior
workingstate while awaiting approvalFlow Testing
bash samples/python/scenarios/a2a/human-present/upi_collect/run.shNotes