Skip to content

Submit Exercise 2#3

Open
winsxx wants to merge 3 commits intogoodylabs:masterfrom
winsxx:master
Open

Submit Exercise 2#3
winsxx wants to merge 3 commits intogoodylabs:masterfrom
winsxx:master

Conversation

@winsxx
Copy link

@winsxx winsxx commented Jan 5, 2015

Using CodeIgniter, PHP Framework

@grzegorzblaszczyk
Copy link
Member

Your pull request looks fine and it works fine.
It would be awesome, if you could add a few tests to your code (unit tests) for the following scenarios:

  • liters given as a string (not a number)
  • number of kilometers - value given lower than 0
    etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants