Always provide metadata to encoding functions #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencoppock
force-pushed
the
always-pass-metadata
branch
2 times, most recently
from
97b6c39 to
b594046
Compare
This struct enables encoding when it's necessary to know the number of registers/bits being encoded into. It also allows better error messages since we provide the name of the mapping.
bencoppock
force-pushed
the
always-pass-metadata
branch
from
b594046 to
204a764
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing this struct enables encoding when it's necessary to know the number of registers/bits being encoded into. It also allows better error messages since we provide the name of the mapping.