Misc fixes #299
Merged
Misc fixes #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately we still need these fallbacks for Mypy to be happy because `bool` is not the same as `Literal[True] | Literal[False]`, so something like `Synset.relations(data=(1==2))` would not match one of the literal overloads.
- `|` for typing unions and optionals - dataclass `slots=True` - non-string type aliases - explicit TypeAlias - 'match' statement pattern matching
This wasn't really a namespace package, so it should probably have an __init__.py file, even if worked without it.
- `C4` comprehensions - `LOG` logging - `SIM` simplifications - `UP` updating to newer python features
This required a few `# type: ignore` comments where ty and mypy don't agree or can't correctly infer the type, but for now both type checkers are relatively happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some long delayed and other opportunistic code cleanup.