Move ILI functions to wn.ili module #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps avoid cyclic imports for upcoming wn.ili module. It also makes the _core module a bit more manageable.
Resolves #282 This commit also cleans up a bit of linting and type-checking issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces
Synset.ilito only have a string identifier orNone, since this the main usage of them, and all ILI class modeling and higher-level functionality goes to awn.ilimodule. This thus follows Larry Wall's maxim easy things should be easy, and hard things should be possible.This change makes it more difficult to get at proposed ILIs (e.g., synsets don't indicate whether they have one or not), but not without justification. Proposed ILIs cannot be used in interlingual queries, and arguably their only use is for lexicographers and CILI maintainers, not everyday users of Wn.
This change also makes it so ILI metadata is on the ILI definition rather than ILI objects themselves. This is more accurate according to where the metadata comes from in WN-LMF.