Add batch check methods, safety features, and bug fixes#57
Merged
luthermonson merged 1 commit intomainfrom Jan 6, 2026
Merged
Conversation
Features added: - HasAll(): Check if IP has all specified hostnames - HasAny(): Check if IP has any of specified hostnames - CheckAll(): Get map of hostname existence status - Backup(): Create backup before modifying hosts file - BackupTo(): Create backup to custom location - HasBeenModified(): Detect concurrent modifications Bug fixes: - Fix comment parsing to preserve multiple # characters Safety improvements: - Add modTime tracking for modification detection - Enable pre-write safety checks Tests: - Add comprehensive tests for all new features - Add regression test for multi-# comment parsing This addresses VVV requirements for: - Checking hosts without sudo (read-only operations) - Preventing data loss with backups - Better comment preservation
This was referenced Dec 30, 2025
Member
|
To me it make sense what do you think @luthermonson ? |
luthermonson
approved these changes
Jan 6, 2026
Contributor
|
makes sense to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to support checking hosts before attempting to modify files with
sudo, and attempting to fix some edge cases around host file comments and race conditions.Features added:
Bug fixes:
Safety improvements:
Tests: