pass save_state to cc2tas:pushstate so it actually saves the state#10
Open
WyWy21 wants to merge 1 commit intogonengazit:masterfrom
Open
pass save_state to cc2tas:pushstate so it actually saves the state#10WyWy21 wants to merge 1 commit intogonengazit:masterfrom
WyWy21 wants to merge 1 commit intogonengazit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cc2tas:pushstate parameters seemed to not get updated after savestate_every was added. This led to frames not getting saved because save_state was nil. If you rewind and there are no saved frames the tas tool while crash because there is no frame to go to (or something like that).