Open
Conversation
Member
|
It looks like we just need the minor fix to load-moveit-scene and symbol exports in commit 37ce51d. The other script/commits don't seem to belong in the library. |
ndantam
added a commit
that referenced
this pull request
May 8, 2022
Fixed bug where RotMat->Quat conversion would not give a minimized quaternion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this should be merged into master, but it could probably live in its own branch for easy access by people who are interested in this functionality. In essence, this PR allows one to make use of the existing functions which were commented out, and contains a utility script specific to TMKit that demonstrates their usage.