Conversation
The existing implementation of the Intel x86 doc parser matches headers by just trimming spaces. However, there are cases, when a header string takes several lines, which breaks current switch case matching, e.g. during the parsing of AMX operations. This commit fixes it by replacing \n with a whitespace in a header string. For: #61079
|
This PR (HEAD: 0d9feca) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555. Important tips:
|
|
This PR (HEAD: 1f785a7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555. Important tips:
|
|
Message from Anton Kuklin: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
|
Message from Cherry Mui: Patch Set 2: Run-TryBot+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
|
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
|
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
|
This PR (HEAD: e97199f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555. Important tips:
|
|
This PR (HEAD: 08f9014) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/arch/+/510555. Important tips:
|
|
Message from Anton Kuklin: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
|
Message from Anton Kuklin: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
|
Message from Cherry Mui: Patch Set 2: Run-TryBot+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
|
Message from Gopher Robot: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
|
Message from Gopher Robot: Patch Set 2: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
|
Message from Anton Kuklin: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/510555. |
The existing implementation of the Intel x86 doc parser matches headers by just trimming spaces. However, there are cases, when a header string takes several lines, which breaks current switch case matching, e.g. during the parsing of AMX operations. This commit fixes it by replacing \n with a whitespace in a header string.
For: golang/go#61079