Skip to content

feat: override builtin commands #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CatsDeservePets wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat: override builtin commands #2334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57b9a24
feat: add `builtin` command
CatsDeservePets Dec 31, 2025
2af47fe
feat: add completions for `builtin`
CatsDeservePets Dec 31, 2025
970817a
feat: prevent problems with some commands
CatsDeservePets Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions complete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ var (
"cmd",
"addcustominfo",
"bottom",
"builtin",
"calcdirsize",
"cd",
"clear",
Expand Down Expand Up @@ -473,6 +474,10 @@ func completeCmd(acc []rune) (matches []compMatch, result string) {
if len(f) == 2 {
matches, result = matchCmdFile(f[1], false)
}
case "builtin":
if len(f) == 2 {
matches, result = matchCmd(f[1])
}
case "toggle":
matches, result = matchCmdFile(f[len(f)-1], false)
default:
Expand Down
28 changes: 22 additions & 6 deletions eval.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,27 @@ func exitCompMenu(app *app) {
func (e *callExpr) eval(app *app, _ []string) {
os.Setenv("lf_count", strconv.Itoa(e.count))

noOverride := []string{
"open",
"paste",
"delete",
"rename",
}

if e.name == "builtin" {
if len(e.args) == 0 {
app.ui.echoerr("builtin: requires at least 1 argument")
return
} else if e.args[0] == "builtin" {
app.ui.echoerr("builtin: recursive call")
return
}
e.name, e.args = e.args[0], e.args[1:]
} else if cmd, ok := gOpts.cmds[e.name]; ok && !slices.Contains(noOverride, e.name) {
cmd.eval(app, e.args)
return
}

silentCmds := []string{
"addcustominfo",
"clearmaps",
Expand Down Expand Up @@ -2260,12 +2281,7 @@ func (e *callExpr) eval(app *app, _ []string) {
case "on-init":
onInit(app)
default:
cmd, ok := gOpts.cmds[e.name]
if !ok {
app.ui.echoerrf("command not found: %s", e.name)
return
}
cmd.eval(app, e.args)
app.ui.echoerrf("command not found: %s", e.name)
}
}

Expand Down