refactor: remove init flag #2313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hi @CatsDeservePets, did you have any other comments about this PR, or did you want some more time to test the changes? |
Collaborator
I will test it some more. |
CatsDeservePets
approved these changes
Jan 2, 2026
Collaborator
|
Sorry for taking so long. I could not find any more obvious issues and had either the same or "improved" behaviour when compared to the older code. The only thing that might be confusing is the difference in wording for some error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely large refactor:
nav.dirs, which storesdirobjects separately from the directory cache, and can cause confusion. Now alldirobjects will be stored in only the directory cache, and looked up when required.nav.initflag. This was previously used to ensure thatnav.dirswas not being accessed if it was empty (i.e. before initialization).currDirandcurrFilenow load directories from the system if they are not present in the cache, so that they always return something.Hopefully this doesn't cause any crashes or other regressions. It is a very large change though so it could take some time to become stable.