-
Notifications
You must be signed in to change notification settings - Fork 356
chore!: change to use v3 of Tcell #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Uppercase letters get reported incorrectly for me as well. On a side note: I've noticed you've been using conventional commits more often lately. I try to align my commit messages to match the repos style. If you plan to stick with them going forward, I will use them as well. |
|
I fixed the upper case keys issue. Sorry about that! |
Yes, it's something I have decided to adopt from now on, since many other projects are using it too. I am uncertain about actually enforcing it though (e.g. via CI), or using it as a replacement for the existing |
Cool, I am all for unification. I have been using them myself in privat projects (although I am using the Angular guidelines which famously dropped I guess using it for commit messages is good for now, we can always expand on that later. |
Changes:
Support for SGR 8 (concealed text) is removed as Tcell has dropped support for it. This is a breaking change, however it is a very niche feature and I don't think users are interested in it anyway.<backspace2>keybindings to<backspace>, since Tcell does this internally. This is a breaking change, however it should be a welcome one as it unifies<backspace>and<backspace2>, which reduces confusion.ui.keyAccandui.keyCountare changed from[]runetostring, since key events in Tcell now store astringinstead of arune. This makes the code easier to work with.<space>/<c-a>).SetContentcalls withPutStrStyled, this requires rewriting thewin.printfunction to accommodate for the new API.Anyway I will plan to leave this PR open for a while, and only merge it when it (and the new version of Tcell) becomes more stable.
Warning
Apparently keybindings for capital letters (e.g.Gforbottom) don't work in v3 of Tcell. at least for me. I have raised an issue about it.Fixed now, but I still plan to leave this PR open for a while regardless, not in a rush to merge.