Skip to content

Conversation

@thatarchguy
Copy link
Contributor

Just a low hanging fruit typo I noticed.

@Vad1mo
Copy link
Member

Vad1mo commented Jan 28, 2026

please open PR towards main

@thatarchguy thatarchguy changed the base branch from release-2.14.0 to main January 28, 2026 15:10
neginkheirmand and others added 2 commits January 28, 2026 10:15
[fix typo]: Missing space

Signed-off-by: Negin Kheirmand <neginkheirmand@gmail.com>
Signed-off-by: Kevin <thatarchguy@users.noreply.github.com>
@thatarchguy
Copy link
Contributor Author

I changed the targets and rebased main against my branch. It wants to pull in that other commit. I believe because it was merged to 2.14.0 and not main.
#688

I can remake this PR, but that fix will be lost if so. Let me know how you want me to proceed.

@Vad1mo Vad1mo enabled auto-merge (squash) January 28, 2026 16:56
@Vad1mo Vad1mo self-requested a review January 28, 2026 16:56
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vad1mo Vad1mo merged commit 57b8d73 into goharbor:main Jan 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants