line 36 has been changed in https://github.com/godong9/solr-node/pull…#92
Open
gyula-s wants to merge 1 commit intogodong9:masterfrom
Open
line 36 has been changed in https://github.com/godong9/solr-node/pull…#92gyula-s wants to merge 1 commit intogodong9:masterfrom
gyula-s wants to merge 1 commit intogodong9:masterfrom
Conversation
|
This issue was added in PR #83 (see also comment on the commit). #84, referenced above as the cause, is actually a solution PR that the present PR (#92) exactly duplicates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in pr #84 the line 36 of the index.d.ts has been changed to
suggestQuery(params: SuggestQueryParams | string): this;however the interface itself on line 125 wasn't changed.This causes transpile errors in my ts project.
this pr rectifies this, and hopefully this will allow us to use the package in the future, and we won't have to keep a forked version of this in our dependencies.