Skip to content

fix: use Go's built-in clear() for secure memory wiping #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aka-bo merged 1 commit into from
Aug 12, 2025
Merged

fix: use Go's built-in clear() for secure memory wiping #1442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions go/appencryption/internal/bytes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,9 @@ import (

// MemClr takes a buffer and wipes it with zeroes.
func MemClr(buf []byte) {
for i := range buf {
buf[i] = 0
}

// Prevent dead store elimination, based on https://github.com/golang/go/issues/33325
// and https://github.com/awnumar/memguard/blob/fb1272668ab3188606f9dfec73b2f7865a30603d/core/crypto.go#L105.
// Avoid using memguard directly here in case we change our default secure memory implementation.
runtime.KeepAlive(buf)
// Use Go's built-in clear() function (available since Go 1.21)
// which is guaranteed not to be optimized away by the compiler
clear(buf)
}

// FillRandom takes a buffer and overwrites it with cryptographically-secure random bytes.
Expand Down