Update ginkgo to v2 #439
Merged
Update ginkgo to v2 #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacJames
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ginkgo v1 is deprecated for a long time. This updates to Ginkgo v2.
This would also be used when implementing Analysis generation, as v2 supports table tests syntax sugar DescribeTable.
Changed behavior
CLI flags
Ginkgo cli flags in
Makefilehave been changed from CamelCase to appropriate snake-case.Docs reference.
Acceptance reporter configuration
Change how custom reporter config in acceptance testing is set and used.
Docs reference
BeforeSuitetimeoutSeveral
BeforeSuitenodes insuite_test.gofiles used to have 60-second timeout defined. In v2, these could be defined asNodeTimeoutdecorator, however, doing so would require accepting aContextin the closure, and it doesn't seem that it would be used in the current implementation. Therefore, the timeout was removed - similar approach was taken when upgrading to Ginkgo v2 in controller-runtime.Docs reference - not exactly the same scenario, but offers example of how to add NodeTimeout.