Update Go (build/test) version to 1.23 #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per instructions at https://github.com/kubernetes-sigs/controller-runtime/tree/main/tools/setup-envtest This should prevent current and future breakage.
Update for Go 1.23 - see kubernetes-sigs/controller-tools#880
bencord0
approved these changes
Nov 26, 2024
jace-ys
pushed a commit
to duffelhq/theatre
that referenced
this pull request
Feb 27, 2025
Co-authored-by: Ben Wheatley <contact@benwh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing errors in GH action tests, such as:
This is due to older versions of Go not supporting
X.Y.Zversioning, and prevents any changes due to failing CI.To resolve this, update the Go version used by GH actions to the latest stable
1.23.3. For consistency, also update the version used for build inDockerfileandasdf.tool-versions.Some downstream changes were also done because of this:
0.14- see Controller-gen panic when using go 1.22 kubernetes-sigs/controller-tools#880New release should not be needed since this is a non-functional change.