Disable constant folding to not miss checks in constant expressions #1933
+29
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ants Needed to parse some Linux kernel headers in regression tests which use ternary operator in enum value definition.
sim642
added
bug
pr-dependency
sim642
force-pushed
the
checks-constFold-overflow
branch
from
ca584ea to
da7ab8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CIL folds constant expressions, Goblint never sees the operations, and thus does not appear to perform all the necessary overflow checks. This used to be optional for our first SV-COMP no-overflow implementation in #149.
This reveals new things which probably should be evaluated speculatively.
TODO
lowerConstantscil#215.eval_rv_base.