feat(artifacts): add support for artifacts key#672
Merged
timhuynh94 merged 87 commits intomainfrom Feb 27, 2026
Merged
Conversation
…se, add tests, support stages
…er compose, add tests, support stages" This reverts commit 86a6a7a.
wass3rw3rk
reviewed
Feb 25, 2026
wass3rw3rk
approved these changes
Feb 26, 2026
ecrupper
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This branch wires the worker into the new artifacts + object storage pipeline by:
artifactskey.Architecture
1. Worker config + storage hookup
cmd/vela-worker/flags.go,run.go,worker.gostorage.Setup.Workergains fields forStorage *storage.Setup(config) andStorage storage.Storage(runtime client).cmd/vela-worker/operate.goVelaClient.Storage.GetInfo()to fetch storage configuration from the server.storage.New(...).w.Storageand logs driver/bucket/endpoint.w.Storage = nil.2. Executor setup (linux/local)
executor.Setupnow includes aStorage storage.Storagefield.cmd/vela-worker/exec.gow.Storagewas successfully initialized, it is passed into the executor setup.executor.Setupstruct instead of an inline literal.executor/executor_test.goStoragefield inexecutor.Setup.3. Linux / local executor behavior for artifacts
executor/linux/{build.go,stage.go,outputs.go,report.go,artifacts.go}executor/local/{build.go,stage.go}and related testsThese pieces:
artifactskey, they:4. Runtime integration
runtime/docker/artifacts.go(+artifacts_test.go)runtime/engine.goruntime/kubernetes/container.goPollFileNamesas a no‑op for Kubernetes: artifacts file polling is not supported for dynamic pod environments yet.5. Step skipping, middleware, and wiring
internal/step/skip.go(+ tests)router/middleware/executor/executor_test.goStoragefield inexecutor.Setup.6. Dependencies
go.mod,go.sumsdk-go, server storage packages, and Docker) to versions that include the new artifacts and storage APIs.