Skip to content

chore(outputs): update comments #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 1 commit into from
Sep 12, 2024
+5 −2
Merged

chore(outputs): update comments #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion executor/linux/opts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,12 @@ func WithVersion(version string) Opt {
}
}

// WithOutputCtn sets the outputs container in the executor client for Linux.
func WithOutputCtn(ctn *pipeline.Container) Opt {
return func(c *client) error {
c.Logger.Trace("configuring output container in linux executor client")

// set the version in the client
// set the outputs container in the client
c.OutputCtn = ctn

return nil
Expand Down
2 changes: 1 addition & 1 deletion executor/linux/outputs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (o *outputSvc) destroy(ctx context.Context, ctn *pipeline.Container) error
return nil
}

// update engine logger with secret metadata
// update engine logger with outputs metadata
//
// https://pkg.go.dev/github.com/sirupsen/logrus#Entry.WithField
logger := o.client.Logger.WithField("outputs", ctn.Name)
Expand Down
2 changes: 2 additions & 0 deletions runtime/kubernetes/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ func (c *client) RemoveContainer(ctx context.Context, ctn *pipeline.Container) e
return nil
}

// PollOutputsContainer captures the `cat` response for a given path in the Docker volume.
// This is a no-op for kubernetes. Pod environments cannot be dynamic.
func (c *client) PollOutputsContainer(ctx context.Context, ctn *pipeline.Container, path string) ([]byte, error) {
c.Logger.Tracef("no-op: removing container %s", ctn.ID)

Expand Down