Skip to content

fix(util): use filepath matching for allowlist#1426

Merged
ecrupper merged 1 commit intomainfrom
fix/util/allowlist-func
Mar 30, 2026
Merged

fix(util): use filepath matching for allowlist#1426
ecrupper merged 1 commit intomainfrom
fix/util/allowlist-func

Conversation

@ecrupper
Copy link
Copy Markdown
Contributor

If the allowlist contained <org-A>/* and a repo with the org org-A* was enabled, it would pass this check

@ecrupper ecrupper requested a review from a team as a code owner March 30, 2026 19:56
Copy link
Copy Markdown
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually sane

@ecrupper ecrupper merged commit 3b28752 into main Mar 30, 2026
10 of 12 checks passed
@ecrupper ecrupper deleted the fix/util/allowlist-func branch March 30, 2026 20:00
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.08%. Comparing base (4bd1e01) to head (a6a3e9b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1426      +/-   ##
==========================================
+ Coverage   58.04%   58.08%   +0.03%     
==========================================
  Files         663      663              
  Lines       25511    25508       -3     
==========================================
+ Hits        14809    14816       +7     
+ Misses      10005     9995      -10     
  Partials      697      697              
Files with missing lines Coverage Δ
util/util.go 24.63% <100.00%> (+10.74%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants