Skip to content

feat: oidc provider#315

Merged
ecrupper merged 10 commits intomainfrom
feat/oidc-provider
Jun 5, 2024
Merged

feat: oidc provider#315
ecrupper merged 10 commits intomainfrom
feat/oidc-provider

Conversation

@plyr4
Copy link
Copy Markdown
Contributor

@plyr4 plyr4 commented May 30, 2024

sdk implementation for go-vela/server#1120

@plyr4 plyr4 requested a review from a team as a code owner May 30, 2024 14:33
@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.29%. Comparing base (1d75672) to head (09cf990).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   89.56%   89.29%   -0.28%     
==========================================
  Files          21       21              
  Lines         834      850      +16     
==========================================
+ Hits          747      759      +12     
- Misses         53       55       +2     
- Partials       34       36       +2     
Files Coverage Δ
vela/build.go 89.33% <75.00%> (-3.89%) ⬇️

@ecrupper
Copy link
Copy Markdown
Contributor

ecrupper commented Jun 3, 2024

Should we also add GetIDToken? Might be useful for plugins written in Go?

Copy link
Copy Markdown
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit db84c9a into main Jun 5, 2024
@ecrupper ecrupper deleted the feat/oidc-provider branch June 5, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants