Use the same oauth flow across different operating systems#84
Open
orkhanM wants to merge 4 commits intogo-schwab:mainfrom
Open
Use the same oauth flow across different operating systems#84orkhanM wants to merge 4 commits intogo-schwab:mainfrom
orkhanM wants to merge 4 commits intogo-schwab:mainfrom
Conversation
* standardize return types
Signed-off-by: Orkhan Mamedov <orkhanM@users.noreply.github.com>
Member
|
Ooh, I will review this later today! I have been putting off doing this for a while because I've been working on other projects, thanks for taking a shot at it! |
Author
|
Thanks @samjtro! |
Member
|
Sorry this took so long, it's been an insane last few weeks. I really like what you've done here, will test and get this merged tonight. Thanks so much for your contribution! |
Author
|
@samjtro no worries! Please let me know if you find any issues, I pushed a change to go-schwab/utils#1 yesterday as I realized I hadn't removed a print I'd previously added for debugging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have linux use the same oauth flow as implemented for other operating systems.
Related PR: go-schwab/utils#1