Windows support (until external linking will be supported by go build)#149
Open
Windows support (until external linking will be supported by go build)#149
Conversation
Removes all dynamic_cast, in order to make it work without RTTI. This is due to golang/go#10023 (duplicate of golang/go#4069) and solves go-qml#19.
Make it work without global variable initialization. This is due to golang/go#10023 (duplicate of golang/go#4069) and solves go-qml#142.
neclepsio
changed the title
Cleanup
Cleanup (tabs to spaces)
|
this pr fix the crash on windows, thx. |
|
This fix works. Thank you! |
Added proper casting from QMetaType::User (1024) with userType 1034 (i.e., QJSValue) to QVariant so it can be handled properly by the packDataValue method.
Go 1.6 cannot have Go pointer stored into the cgo space. So instead we need to store all Go values in a map and pass a key to the cgo space. When needed the key can be used to retrieve the go value from the map.
Go 1.6 (final)
# Conflicts: # cpp/idletimer.cpp
Using the C.GoRef datatype instead of uintptr in the go code make it more clear what the variable contains.
added methods to the type so that we can get the GoRef and register the fold in the lookup table, then a function to destroy the reference when we are done with the valueFold.
Go1.6 port
When unpacking a DataValue of a DTGoAddr type, we forgot to dereference the datap pointer that contained the GoRef. Thanks to immesys on github, for pointing out the bug.
fix forgotten dereferenced datap pointer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fork aims to make go-qml work under Windows, for which the absence of external linking in go build makes global variable initialization and dynamic_cast unusable. See golang/go#4069.
Solves #19 and #142.