Skip to content

feat: add type definitions#50

Open
unional wants to merge 4 commits intogo-macaroon:masterfrom
unional:typings
Open

feat: add type definitions#50
unional wants to merge 4 commits intogo-macaroon:masterfrom
unional:typings

Conversation

@unional
Copy link
Copy Markdown

@unional unional commented Apr 19, 2020

Adding TypeScript type definitions to the library.

@hatched
Copy link
Copy Markdown
Collaborator

hatched commented Apr 21, 2020

Thanks for this PR!

I just wanted to let you know that I've seen this and will get to it as soon as I can.

In response to your question on #49 We'd definitely be interested in converting this to TS, I've created an issue to hold discussions around this topic #53

@unional
Copy link
Copy Markdown
Author

unional commented Apr 21, 2020

I have a TS version in my fork. I'll do some clean up and then file a PR . :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants