Fix issues in adding goerli support#845
Open
AireshBhat wants to merge 4 commits intognosis:goerli-supportfrom
Open
Fix issues in adding goerli support#845AireshBhat wants to merge 4 commits intognosis:goerli-supportfrom
AireshBhat wants to merge 4 commits intognosis:goerli-supportfrom
Conversation
AireshBhat
commented
Dec 12, 2022
AireshBhat
commented
- Fixed issue in Goerli name. Changed from "GOERLI" to "GÖRLI" wherever necessary.
- Update chain id from 4 to 5 in the connectors file.
segun
reviewed
Dec 12, 2022
| }), | ||
| 4: new WalletConnectConnector({ | ||
| rpc: { 4: NETWORK_CONFIGS[4].rpc }, | ||
| 5: new WalletConnectConnector({ |
There was a problem hiding this comment.
This change will remove support for rinkeby...I think add a new option for Goerli and leave chain id 4 as it is.
Author
There was a problem hiding this comment.
Right, the previous commit in this branch mentioned that Rinkeby support was to be removed in replace of Goerli. There was no reference to Rinkeby in the code apart from this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.