Conversation
| }, | ||
| "dependencies": { | ||
| "@amcharts/amcharts4": "^4.10.13", | ||
| "@anxolin/walletconnect-connector": "6.1.9", |
There was a problem hiding this comment.
I think you don't need to use my library any more :)
u are welcome to use it, but this was a temporal fix while they would accept my PR
| import { NETWORK_URL_MAINNET, PORTIS_ID } from '../constants/config' | ||
| import { ChainId, NETWORK_CONFIGS } from './../utils/index' | ||
|
|
||
| const POLLING_INTERVAL = 10000 |
There was a problem hiding this comment.
Polling has now been disabled as mentioned here
henrypalacios
force-pushed
the
671-wcmodal-appears-after-discn
branch
from
e7edda6 to
1c16ba3
Compare
|
josojo
left a comment
josojo
left a comment
There was a problem hiding this comment.
Super nice. Thanks a lot for this clean up PR
There was a problem hiding this comment.
Hi @henrypalacios , great that you have added these changes!
But I would vote not for deploying them now due to I have found several issues:
-
Wallet is unknown when connected to a WC wallet
-
I can't connect to TrustWallet, imToken wallet: I get the connected message in the wallet, but no active connection log in the app settings. Eternal loader is displayed in the GA app
-
WC connection is closed when
- the page reload the app
- then open any auction details page --> the wallet is disconnected inside the connected app, but connection is still active in the GA app
See the video: it is recorded for the Gnosis safe wallet, but the same behavior is applicable to the TockenPocket, DeFi, MM wallet.
As the result, I can't place an order:
4 participants
Summary
Closes #671
Proposal:
Update dependencias related to
walletconnectand adjust the code that resolve this conflict.Credit to @nenadV91 who referenced.