Skip to content

Conversation

@gnoblet
Copy link
Owner

@gnoblet gnoblet commented Oct 19, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 19, 2025 23:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR revamps the website layout by simplifying the styling system and transitioning from custom R-based gallery generation to Quarto's native listing functionality.

Key Changes:

  • Replaced extensive custom SCSS with a streamlined configuration using local Inter font family
  • Migrated from R-generated gallery to Quarto's built-in listing system
  • Removed custom CSS files and consolidated styling

Reviewed Changes

Copilot reviewed 7 out of 34 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
styles.scss Complete rewrite replacing 500+ lines of custom styles with minimal font configuration using local Inter fonts
styles.css Deleted entire custom CSS file (110 lines)
gallery-custom.css Removed complete custom gallery styling (456 lines)
custom.scss Deleted duplicate SCSS configuration file
index.qmd Replaced R-based gallery generation code with Quarto's native listing configuration
_quarto.yml Updated theme configuration to support light/dark modes and added resource directories
posts/2025/week_41/week_41-r.qmd Updated image reference from "plot.svg" to "week_41.png"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

_quarto.yml Outdated
Comment on lines 29 to 30
light: [flatly, styles.scss]
dark: [flatly, styles.scss]
Copy link

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Both light and dark themes use identical configuration. If the same styles.scss applies to both modes without distinction, consider whether separate theme keys are necessary or if styles.scss should include mode-specific styling.

Copilot uses AI. Check for mistakes.
@gnoblet gnoblet merged commit 7d0f30a into main Oct 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants