Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
"node": true
},
"extends": [
"airbnb"
"airbnb",
"eslint:recommended",
"plugin:react/recommended"
],
"globals": {
"document": false,
Expand All @@ -19,12 +21,18 @@
"expect": true,
"sinon": true
},
"parser": "babel-eslint",
"parser": "@babel/eslint-parser",
"plugins": [
"react",
"jsx-a11y",
"import"
],
"parserOptions": {
"requireConfigFile": false,
"ecmaFeatures": {
"jsx": true
}
},
"rules": {
"react/jsx-filename-extension": 0,
"array-bracket-spacing": 2,
Expand Down Expand Up @@ -248,6 +256,12 @@
"jsx-a11y/no-noninteractive-element-interactions": 0,
"jsx-a11y/media-has-caption": 0,
"react/display-name": 0,
"react/function-component-definition": [
2,
{
"namedComponents": "arrow-function"
}
],
"react/jsx-boolean-value": 0,
"react/jsx-closing-bracket-location": 2,
"react/jsx-curly-spacing": [
Expand All @@ -272,8 +286,8 @@
"react/jsx-pascal-case": 2,
"react/jsx-sort-prop-types": 0,
"react/jsx-sort-props": 0,
"react/jsx-uses-react": 2,
"react/jsx-uses-vars": 2,
"react/jsx-uses-react": "error",
"react/jsx-uses-vars": "error",
"react/no-did-mount-set-state": 2,
"react/no-did-update-set-state": 2,
"react/no-multi-comp": 0,
Expand Down Expand Up @@ -331,4 +345,4 @@
"never"
]
}
}
}
12 changes: 2 additions & 10 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ bower_components
# node-waf configuration
.lock-wscript

# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/
Expand Down Expand Up @@ -78,19 +75,12 @@ typings/
# Next.js build output
.next

# Nuxt.js build / generate output
.nuxt
dist

# Gatsby files
.cache/
# Comment in the public line in if your project uses Gatsby and *not* Next.js
# https://nextjs.org/blog/next-9-1#public-directory-support
# public

# vuepress build output
.vuepress/dist

# Serverless directories
.serverless/

Expand All @@ -102,3 +92,5 @@ dist

# TernJS port file
.tern-port

.vercel
Binary file added CV.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
30 changes: 30 additions & 0 deletions Documentation.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
Documentation:

1) First I solved the dependancy problems by looking in the package.json file as when i tried to install it, everything failed. To solve it I did a binary fetch algorthm with the files and tested them, until I found the troubled ones. Then I looked for them and how to install it on the internet and solved it.
2) Then, I Created the skeleton in src/containers/App.jsx, very simple just to check te components.
3) Created all the files of the components just by copying and pasting them to see if they were all working properly.
4) Created the GetData API using fetch-then and working with the values. Playing with the values was the most difficult part for me and where I messed everything at the begeining.
5) after this I just started working with the values, the arrays, objects in order to show them in my app and I did a few things that worked for some variables and some didn´t, but I finished the App by doing it in that way, I also tried looking for ways to solve it on the internet, videos, stackoverflow, tutorials, and tried many ways, most of them failed.
6) after finishing those steps I added some basic CSS. I was more interested in making this whole thing work more than making it to look pretty.
7) I did my first commit, not to lose the changes.
8) I ran the tests and they failed, almost all. I also noticed by looking inside the test files and runing the tests that there was a directory missing, so I added the directory and file there.
9) I had a look back at the source code and correct some things with the getData function, I kept runing it but keep failing.
10) I started rechecking the components and I cleaned a bit all the mess I did while playing with the different kind of values handed in by the api. And I used the map method for everything as it was simpler but I had some cases it didn't work directly and there I got help from some friend and they told me to add the ternary comparator to check and the things started to work and to pass the tests.
11) I tried to deploy in github pages, in netlify but all attempts were worthless, I asked for help and my classmates helped me using vercel to deploy it.
12) I had to upload the github files there, set the configuration for the sistem to know were my files were and then deploy it. It took some time but finally worked.
13) After deploying I had quite a difficult time changing the localhost of the api to an actual valid ID as git were not taking my changes but that got solved too.

CV Deployed=> https://react-eth-challenge-five-delta.vercel.app/

To run the page I just do:
1) GIT clone
2) I errase REACT and REACT-dom from the package.json
3) npm install
4) npm install react react-dom
5) npm run server
6) npm start
7) npm run test

Images.
1) Tests working in "Test.png"
2) CV working in localhost "CV.png"
18 changes: 9 additions & 9 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
## DESCRIPTION

Solución al reto:
Solución al reto: Everything solved, ran test properly and deployed (https://react-eth-challenge-five-delta.vercel.app/)

Nombre:
Usuario Platzi:
Usuario Platzi: crisme1989

## Reto:

- [ ] Primer problema
- [ ] Segundo problema
- [ ] Tercer problema
- [ ] Cuarto Problema
- [ ] Quinto Problema
- [ ] Sexto Problema
- [ ] Septimo Problema
- [] Primer problema
- [] Segundo problema
- [] Tercer problema
- [] Cuarto Problema
- [] Quinto Problema
- [] Sexto Problema
- [] Septimo Problema
Binary file added Tests.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions build/assets/main.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions build/bundle.js

Large diffs are not rendered by default.

29 changes: 29 additions & 0 deletions build/bundle.js.LICENSE.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
/**
* @license React
* react-dom.production.min.js
*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

/**
* @license React
* react.production.min.js
*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/

/**
* @license React
* scheduler.production.min.js
*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
1 change: 1 addition & 0 deletions build/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!doctype html><html lang="es"><head><meta charset="UTF-8"><meta name="viewport" content="width=device-width,initial-scale=1"><meta http-equiv="X-UA-Compatible" content="ie=edge"><title>My CV</title><meta name="description" content="Place where I can show people my CV"><script defer="defer" src="bundle.js"></script><link href="assets/main.css" rel="stylesheet"></head><body><div id="app"></div></body></html>
123 changes: 88 additions & 35 deletions data.json
Original file line number Diff line number Diff line change
@@ -1,75 +1,120 @@
{
"data": {
"name": "Melissa Walsh",
"profession": "FrontEnd Developer",
"address": "Bogotá, Colombia.",
"email": "melissa@example.com",
"name": "Cristian Marchese",
"profession": "Engineer in Electronics",
"address": "Bs As, Argentina.",
"email": "cmarchesetdiii@gmail.com",
"website": "https://example.com",
"phone": "3042034240",
"avatar": "https://arepa.s3.amazonaws.com/melissa.jpg",
"Profile": "Ignore the squirrels, you'll never catch them anyway hack, for floof tum, tickle bum, jellybean footies curly toes climb leg roll over and sun my belly, ",
"phone": "555corriente",
"avatar": "https://media-exp1.licdn.com/dms/image/C4D03AQFrer5xMiLgtA/profile-displayphoto-shrink_800_800/0/1517856494845?e=1663804800&v=beta&t=mhJ8UIuCwt0kJ3HYd52lJmaNLQFzw0Mr-JWQyRvJLSY",
"Profile": "I am an Electronic Engineer currently working on blockchain.",
"certificate": [
{
"date": "Jan 2021",
"description": "Hack up furballs try to jump onto window and fall while scratching at wall. ",
"date": "Jul 2022",
"description": "An advanced course of react that I'll have to check. ",
"institution": "Platzi",
"name": "FrontEnd Developer"
"name": "React avanzado"
},
{
"date": "Jan 2021",
"description": "Scratch at the door then walk away wack the mini furry mouse",
"date": "Jul 2022",
"description": "A course for beginers in React",
"institution": "Platzi",
"name": "Backend Developer"
"name": "Introduccion a React"
}
],
"Academic": [
{
"degree": "Atomic Master",
"description": " I’m so hungry i’m so hungry but ew not for that pelt around the house and up and down stairs chasing phantoms",
"degree": "Engineer in Electronics",
"description": "A 6 year-degree that took me much more than that.",
"endDate": "Jan 2017",
"institution": "MIT",
"startDate": "Jan 2018"
"institution": "UTN",
"startDate": "Apr 2008"
},
{
"degree": "Space Engineering",
"description": "Meow in empty rooms. Find empty spot in cupboard and sleep all day check cat door for ambush 10 times before coming in for hack. ",
"endDate": "Decenber 2015",
"institution": "Harvard",
"startDate": "Jan 2017"
"degree": "Electronic Technician",
"description": "Motorola certified Technician",
"endDate": "Dec 2007",
"institution": "Harper college",
"startDate": "Jan 2005"
},
{
"degree": "Taekwondo Instructor",
"description": "ITF",
"endDate": "Present",
"institution": "Harper college",
"startDate": "Mrch 1995"
},
{
"degree": "Music",
"description": "Abandoned",
"endDate": "2014",
"institution": "Harper college",
"startDate": "Mrch 2009"
}
],
"experience": [
{
"company": "PugStar",
"company": "Fintech",
"endDate": "Present",
"jobDescription": "scratch the furniture. Good now the other hand, too lay on arms while you're using the keyboard.",
"jobTitle": "Frontend",
"startDate": "Jan 2020"
"jobDescription": "tokenization for a fintech start up.",
"jobTitle": "CTO",
"startDate": "Dec 2021"
},
{
"company": "Freelancer",
"endDate": "May 2022",
"jobDescription": "Blockchain programing and full stack developer.",
"jobTitle": "Blockchain developer",
"startDate": "Dec 2018"
},
{
"company": "CatStore",
"endDate": "Jan 2016",
"jobDescription": "Meow in empty rooms lick left leg for ninety minutes, still dirty.",
"jobTitle": "Backend",
"startDate": "Sept 2019"
"company": "UTN-UBA-INTI-Allegro Microsystems",
"endDate": "Dec 2018",
"jobDescription": "Designing integrated circuits.",
"jobTitle": "Asic Designer",
"startDate": "April 2010"
}
],
"skills": [
{
"name": "HTML5",
"percentage": "75%"
"percentage": "85%"
},
{
"name": "CSS",
"percentage": "25%"
"percentage": "30%"
},
{
"name": "JavaScript",
"percentage": "55%"
"percentage": "20%"
},
{
"name": "React",
"percentage": "5%"
},
{
"name": "Solidity",
"percentage": "90%"
},
{
"name": "Php",
"percentage": "85%"
},
{
"name": "C",
"percentage": "90%"
},
{
"name": "Assembly",
"percentage": "70%"
},
{
"name": "Verilog",
"percentage": "40%"
},
{
"name": "sql",
"percentage": "40%"
}
],
"interest": [
Expand All @@ -85,7 +130,15 @@
},
{
"name": "English",
"percentage": "90%"
},
{
"name": "Swedish",
"percentage": "50%"
},
{
"name": "German",
"percentage": "30%"
}
],
"social": [
Expand All @@ -99,7 +152,7 @@
},
{
"name": "github",
"url": "https://github.com/"
"url": "https://github.com/DigiCris"
},
{
"name": "linkedin",
Expand Down
Loading