Skip to content

ng2-breadcrumb has been migrated to Angular 5 (ng5-breadcrumb)#94

Open
aissam-ahbar wants to merge 3 commits intogmostert:masterfrom
akiocloud:master
Open

ng2-breadcrumb has been migrated to Angular 5 (ng5-breadcrumb)#94
aissam-ahbar wants to merge 3 commits intogmostert:masterfrom
akiocloud:master

Conversation

@aissam-ahbar
Copy link

No description provided.

imports: [
CommonModule
],
declarations: [BreadcrumbComponent]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the export for BreadcrumbComponent. Without this export the module won't work on its own. In your example app.module.ts you declare the component and service manually,

@udayvunnam
Copy link

Issue after upgrading to ng5-breadcrumb and Angular 5.0

getting below error in console
compiler.js:466 Uncaught Error: Template parse errors:
Can't bind to 'useBootstrap' since it isn't a known property of 'breadcrumb'. ("

][useBootstrap]="false" prefix="Pepper Ops">

"): ng:///PagesModule/PagesComponent.html@30:16 'breadcrumb' is not a known element:

If 'breadcrumb' is an Angular component, then verify that it is part of this module.
To allow any element add 'NO_ERRORS_SCHEMA' to the '@NgModule.schemas' of this component. ("
[ERROR ->]

Fixing an issue in getFriendlyNameForRoute leading to a compilation error with typescript.
@aissam-ahbar
Copy link
Author

aissam-ahbar commented Nov 11, 2017

Hi guys,

I fixed this issue coming from a missing export of the ng5-breadcrumb module.

To download it, just use npm to install the ng5-breadcrumb:
https://www.npmjs.com/package/ng5-breadcrumb

Regards,
Aissam

@evanjmg
Copy link
Contributor

evanjmg commented Nov 12, 2017

This doesn’t seem to work with the latest on npm

@evanjmg
Copy link
Contributor

evanjmg commented Nov 12, 2017

I added the exports to the npm module, all my builds were fixed but no breadcrumbs appeared on my lazy loaded modules like before. Until this is fixed, I'm copying the source and importing the old ng2-breadcrumb directly into my angular 5 project and if I can fix that aot error I'll make a pull to this repo. @aissamJ thanks for fixing the build issues, but I can't get the components to work. I think a very small pull request fixing the aot issues for angular 5 will suffice

@evanjmg
Copy link
Contributor

evanjmg commented Nov 12, 2017

Upon adding the old ng2-breadcrumb directly into a massive sass project (30+ components use breadcrumbs lazily) without npm, everything works properly. It is simply the build system and exporting that needs reworking - not a complete rewrite or reformatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants