Iss81 - Fixed strictNullChecks TS option incompatibility#90
Open
pascallaprade wants to merge 4 commits intogmostert:masterfrom
Open
Iss81 - Fixed strictNullChecks TS option incompatibility#90pascallaprade wants to merge 4 commits intogmostert:masterfrom
pascallaprade wants to merge 4 commits intogmostert:masterfrom
Conversation
added 3 commits
October 31, 2017 22:20
Also introduced npm 5+ package-lock.json file to project.
Since Angular 4+, this option is supported, but this library did not support it, causing compile issues for users wishing to use stricter rules in their project. This commit brings support for this option to the library.
Author
|
I updated the pull request by resolving issue #91 as well, since they were related, and since a fix for #91 would need the previous fix in order to be implemented. Only one part of the code didn't compile under strict rules, and it was once again only a wrong type that was previously ignored by TypeScript, so I thought the change was small enough to be included in this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to close issue #81.
Since Angular 4+ (which this library targets), the strictNullChecks TypeScript compiler option is officially supported by the Angular project.
This means that users wishing to enforce stricter compiler rules for their projects should be able to do so.
However, this library did not support that option, because one of the variable was incorrectly typed.
This pull request brings official support for this option, just like the Angular project itself, by adding that option to its compiler options. It also fixes the faulty line that did not pass that check.