Make bootstrap optional on a package level#79
Open
eitland wants to merge 1 commit intogmostert:masterfrom
Open
Make bootstrap optional on a package level#79eitland wants to merge 1 commit intogmostert:masterfrom
eitland wants to merge 1 commit intogmostert:masterfrom
Conversation
According to the readme "Optionally uses bootstrap.css (v 3.x.x) for styling of some elements (although the component is fully functional without it and there is a flag to turn off the dependency)." I was however not able to find that flag. With the above change it should install without even pulling in the bootstrap package, just by specifying --no-optional on npm install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the readme "Optionally uses bootstrap.css (v 3.x.x) for styling of some elements (although the component is fully functional without it and there is a flag to turn off the dependency)."
I was however not able to find that flag.
With my changes it should install without even pulling in the bootstrap package, just by specifying --no-optional on npm install.