-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: opencode canonical #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gmickel
commented
Jan 16, 2026
- Canonicalize .opencode (remove legacy plugin/sync paths)
- Move docs to docs/ and update links
- Require verdict in Ralph receipts
- Update changelog 0.2.3
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90c4a3c92b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if kind in ("plan_review", "impl_review"): | ||
| verdict = data.get("verdict") | ||
| if verdict not in ("SHIP", "NEEDS_WORK", "MAJOR_RETHINK"): | ||
| sys.exit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update Ralph receipt templates to include verdict
The new receipt validation rejects plan/impl receipts unless they include a valid verdict, but the Ralph prompt templates (.opencode/skill/flow-next-ralph-init/templates/prompt_plan.md and prompt_work.md) still instruct writing receipts with only type/id/mode/timestamp. In Ralph runs with plan/work review enabled, the agent will follow those templates and generate receipts missing verdict, so verify_receipt fails and the run is forced into retry. Update the receipt templates (and any receipt-writing commands) to include the verdict field so the new validation can pass.
Useful? React with 👍 / 👎.
| # Write patch file | ||
| # OpenAI input name pattern disallows dots; use safe filenames. | ||
| patch_path = "/tmp/flow-next-impl-review-patch" | ||
| try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a portable temp directory for opencode review files
cmd_opencode_impl_review writes patch/prompt files to fixed /tmp/... paths. On Windows (and any environment without /tmp), Path(...).write_text will raise FileNotFoundError before the review runs, breaking flowctl opencode impl-review (and plan-review, which also uses /tmp). Consider using tempfile.gettempdir() or NamedTemporaryFile so the commands work across platforms.
Useful? React with 👍 / 👎.