sync: flowctl efficiency #2
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5c76674c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Restore tasks | ||
| tasks_dir = flow_dir / TASKS_DIR | ||
| restored_tasks = [] | ||
| for task in checkpoint["tasks"]: | ||
| task_id = task["id"] |
There was a problem hiding this comment.
The restore path only rewrites tasks present in the checkpoint but never deletes tasks created after the checkpoint. If a user saves a checkpoint, adds new tasks under the epic, and then runs checkpoint restore, those extra task JSON/spec files remain, so the epic is not actually rolled back to the snapshot (e.g., plan review and status will still see the post‑checkpoint tasks). Consider pruning any fn-N.* task files not listed in the checkpoint before writing restored tasks to make restore semantics match the snapshot.
Useful? React with 👍 / 👎.
sync upstream flowctl efficiency + docs