Skip to content

Chore: Restructure Library Architecture#5

Merged
gmemmy merged 5 commits intomainfrom
chore/restructure-lib
Oct 14, 2025
Merged

Chore: Restructure Library Architecture#5
gmemmy merged 5 commits intomainfrom
chore/restructure-lib

Conversation

@gmemmy
Copy link
Owner

@gmemmy gmemmy commented Oct 10, 2025

No description provided.

@gmemmy gmemmy marked this pull request as draft October 10, 2025 23:50
Repository owner deleted a comment from coderabbitai bot Oct 10, 2025
@gmemmy gmemmy force-pushed the chore/restructure-lib branch 3 times, most recently from d7f7332 to 9548be3 Compare October 12, 2025 01:26
@gmemmy gmemmy force-pushed the chore/restructure-lib branch from 9548be3 to c774793 Compare October 12, 2025 02:06
@gmemmy gmemmy marked this pull request as ready for review October 12, 2025 10:31
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@@ -0,0 +1,3 @@
import "@visionrtc/source-visioncamera/register";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Import plugin via unexported subpath

The wrapper unconditionally imports @visionrtc/source-visioncamera/register, but the plugin’s package.json only exposes the "." entry and does not export a ./register subpath (packages/source-visioncamera/package.json). With Node/Metro’s package exports resolution this path raises ERR_PACKAGE_PATH_NOT_EXPORTED, so simply importing react-native-vision-rtc fails before any of the APIs run. Import the package root (which already triggers registration) or add "./register" to the plugin’s exports map.

Useful? React with 👍 / 👎.

@gmemmy gmemmy merged commit 1d53088 into main Oct 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant