Cuts down on the perl Record.pm warnings#4
Open
bmagic007 wants to merge 1 commit intogmcharlt:masterfrom
Open
Conversation
Cuts down on the perl warnings when an undefined value makes it's way into the field sub. Tested on 120k bibs for a migration. Tested before/after and found that the result was identical but with the patch, much less noise!
Author
|
Galen, Just wondering if the PR made it's way to you. I dove back into Record.pm again today to figure out why I was getting all those warnings. Implemented a solution. Then decided to contribute the fix only to find that previous-me already did the same thing 6 months ago. -Blake- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts down on the perl warnings when an undefined value makes it's way into the field sub.
Tested on 120k bibs for a migration. Tested before/after and found that the result was identical but with the patch, much less noise!
This is the error message without the patch:
Use of uninitialized value $tag in hash element at /usr/share/perl5/MARC/Record.pm line 202.
(repeated thousands of times, flooding the standard output)