Skip to content

Fix get_speech to include both otid and speech_id#6

Open
boffutt28 wants to merge 2 commits intogmchad:mainfrom
boffutt28:patch-1
Open

Fix get_speech to include both otid and speech_id#6
boffutt28 wants to merge 2 commits intogmchad:mainfrom
boffutt28:patch-1

Conversation

@boffutt28
Copy link

The get speech function requires both otid and speech_id. Currently it sets otid to speech_id which is incorrect.

The get speech function requires both otid and speech_id. Currently it sets otid to speech_id which is incorrect.
Had made param ot_id. Changing to otid to be consistent with Otter.
ChocoTonic added a commit to ChocoTonic/otterai-py that referenced this pull request Mar 17, 2025
Rename parameter 'speech_id' to 'otid' in the
get_speech method for improved clarity and consistency
with existing code. This change aligns the parameter
name with its intended purpose and follows the naming
conventions used throughout the API.

Credit to boffutt28 for the original contribution on
this change at gmchad/otterai-api#6.
@ChocoTonic
Copy link
Collaborator

ChocoTonic commented Mar 17, 2025

Hey @boffutt28,

Thanks for the fix. I’ve made a fork at ChocoTonic/otterai-py since it seems like this project is unmaintained and included your change in this commit. Appreciate it!

@ChocoTonic
Copy link
Collaborator

Adding a bit more context here. While I do have collaborator access, the repository has been largely untouched and I still do not have permission to manage repo secrets, which is required for the integration tests I am trying to add. It has been over a month with no movement on that front.

Given the lack of maintenance activity and the blocker around basic permissions, I am moving forward with active maintenance in the restarted repository at https://github.com/ChocoTonic/otterai-py/ so development and testing can continue without friction.

Going forward, please open any pull requests or contributions against that repository so changes can be reviewed and merged without delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants