This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Open
Conversation
gmarull
reviewed
Feb 21, 2020
Owner
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
Compiled resources depend on PyQt5, what if I use PySide2?
Collaborator
Author
|
Well spotted! Should depend on qtpy |
Jerakin
force-pushed
the
compiling_resources
branch
from
1611605 to
b85a246
Compare
Contributor
|
also makes it a bit harder for the user to make changes to stylesheet etc, not that that matters for most people, but maybe include the uncompiled resources in the next PyPI release too? |
Collaborator
Author
|
That's a good point, we should maybe do something like this. https://github.com/Jerakin/qtmodern/compare/compiling_resources...Jerakin:change_style?expand=1 That way they could at least monkey patch in their own stylesheet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pros
Cons
All in all makes it a lot "it just works" for users, but requires a bit of extra work from the maintainers.