Skip to content
This repository was archived by the owner on May 24, 2020. It is now read-only.

Conversation

@JohnStrunk
Copy link
Member

The lack of socat was preventing Helm from running in the GCS Vagrant
environment. This patch installs socat on the atomic hosts. It also
fetches the kubectl config into the local directory once installation is
complete, making it possible to use kubectl on the local machine to
access the cluster:
$ kubectl --kubeconfig=kubeconfig get nodes

Related to #14

The lack of `socat` was preventing Helm from running in the GCS Vagrant
environment. This patch installs socat on the atomic hosts. It also
fetches the kubectl config into the local directory once installation is
complete, making it possible to use kubectl on the local machine to
access the cluster:
`$ kubectl --kubeconfig=kubeconfig get nodes`

Signed-off-by: John Strunk <jstrunk@redhat.com>
@ghost ghost assigned JohnStrunk Nov 13, 2018
@ghost ghost added the in progress label Nov 13, 2018
@JohnStrunk JohnStrunk requested a review from kshlm November 13, 2018 18:41
docker_mount_flags: "shared"
kube_network_plugin: "flannel"
kube_version: "v1.12.1"
kubeconfig_localhost: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable makes kubespray sync a copy of the kubeconfig to {artifacts_dir}/admin.conf. artifacts_dir defaults to '/artifacts, which is .vagrant/provisioners/ansible/inventory/artifactswith the Vagrant deployment. Setting anartifacts_dir` variable here to "./" should have Kubespray copy the config into the current dir.

Or you could just drop this variable all together.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting artifacts_dir: './' causes the artifacts to be dumped in the kubespray directory, so lets just remove kubeconfig_localhost.

command: "rpm-ostree install {{ item }}"
with_items:
# socat is needed for Helm
- socat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a thought. It may be a good idea to get this change in to Kubespray itself. Kubespray supports deploying helm on the kubernetes clusters it creates, so it should do this as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes-sigs/kubespray#2879 is already opened for this and you've already found it. So this is okay till that gets fixed.

@ghost ghost assigned kshlm Nov 20, 2018
@kshlm kshlm merged commit 395e330 into gluster:master Nov 20, 2018
@ghost ghost removed the in progress label Nov 20, 2018
@JohnStrunk JohnStrunk deleted the socat branch December 19, 2018 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants