Binding expression edition support (no resolution / string only)#279
Binding expression edition support (no resolution / string only)#279treilhes wants to merge 2 commits intogluonhq:masterfrom
Conversation
|
Hello, I wonder if someone can take some time to give it a look |
|
Hi @treilhes, Thank you for the exemplary work in the PR. I am trying to understand the target of the PR. Will binding expression resolution be added as a part of this PR? |
|
It will add binding expression support only for String typed fields. The pull request allows SceneBuilder to show binding expression in the editor (aka ${something}) without trying to resolve it and generate an exception |
abhinayagarwal
left a comment
abhinayagarwal
left a comment
There was a problem hiding this comment.
OK. I have left an initial list of review comments. Please update the license header on every file. I will do more extensive review soon.
| # ----------------------------------------------------------------------------- | ||
| log.info.explore.jar = JAR {0}の探索を開始 | ||
| log.warning.inline.edit.internationalized.strings = 国際化された文字列をインライン編集できません | ||
| log.warning.inline.edit.bindingexpression.strings = Can''t inline edit binding expression strings |
| log.info.explore.folder = Start exploring FOLDER {0} | ||
| log.info.explore.jar = Start exploring JAR {0} | ||
| log.warning.inline.edit.internationalized.strings = Can''t inline edit internationalized strings | ||
| log.warning.inline.edit.bindingexpression.strings = Can''t inline edit binding expression strings |
| if (i18nMode) { | ||
| val = new PrefixedValue(PrefixedValue.Type.RESOURCE_KEY, val).toString(); | ||
| } else if (exprMode) { | ||
| val = new PrefixedValue(PrefixedValue.Type.BINDING_EXPRESSION, val).toString(); |
There was a problem hiding this comment.
Make sure to use 'spaces' instead of 'tabs'. There are multiple other places where tabs have been introduced.
abhinayagarwal
force-pushed
the
master
branch
2 times, most recently
from
7c0a0f0 to
fd0a426
Compare
3 participants
This pull request allow edition of binding expression for string values only.
If the field containing the binding expression is shown in the hierarchy view. It won't be resolved and can't be edited
The warning is kept to inform the user about the presence of a binding expression
If the field containing the binding expression is shown in the scene view. It won't be resolved and can't be edited
If the field containing the binding expression is shown in the previex view. It won't be resolved and can't be edited
#89 seems partialy solved, at least for string fields
#97 binding expression in fields other than string still generate an exception and prevent moving components
Please, feel free to comment or require modifications on this pull request