section name for imported libraries

[safirex]

A minor update changing the section names of imported librairies for more visibility

from

to

[abhinayagarwal]

Hi @safirex ,

Are you still willing to work on this PR?

[safirex]

@abhinayagarwal
hello,
not at the moment, no.

[abhinayagarwal]

Hi @safirex ,

I have left some comments.

I couldn't find you in our contributors list. Can you please sign the Gluon Individual Contributor License Agreement.

[abhinayagarwal]

Looks good. One more change which I missed to point out earlier. Please update the license header on the file to current year:

Copyright (c) 2017, 20202021, Gluon and/or its affiliates

[jperedadnr]

This should be outside the for loop

[abhinayagarwal]

Good catch, José!

[jperedadnr]

In general this PR looks good, providing a section name to categorise all different custom controls definitely would help.

However, if the user happens to have many imported jars, the list grows at the top level, and the number of root categories in the accordion is too big, causing the titled panes not to show any content or barely one or two items of a possibly long list. Also, this will clutter the view, having the built-in categories (like Controls) at the end and barely accessible.

To move this PR forward, we need somehow to introduce the concept of sub-category.

As the library items are currently displayed in a titled pane, using a single ListView<LibraryListItem>, I suggest a few options:

• Use the subcategory title as a Label node, having a ListView control for each jar.
• Create a LibraryListItem to be used as header, for each subcategory, so a single listView will do, however this will require two different custom cells, and figuring out how to sort it (first by sub-category, then by name).
• Based on the above, the CharmListView control is already designed for that. The required refactoring is fairly easy to do.

If we keep the accordion as is (with each custom library as a top categories and no sub-categories), we could add a button to the right of the Search field, so the user can manage the categories, hiding the ones not frequently used.