Performance improvements for fixed resolution buffer #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Jul 25, 2024
…fer to speed up identical pixel transformations across layers (e.g. when subsets are present)
Member
Author
|
@dhomeier - do you understand the ruff issue here? |
Member
|
@dhomeier can correct me if I'm wrong, but I think what it wants is # `value` is a bad variable name but I don't know what this thing is
for chid, value in PIXEL_CACHE.items():
if value['hash'] == current_pixel_hash:
for ipix, pix in enumerate(data.pixel_component_ids):
if (
ipix not in matching_pixel_cache and
ipix in value and
value[ipix]['bounds'] == bounds
):
matching_pixel_cache[ipix] = value[ipix]rather than (what is currently is): for chid in PIXEL_CACHE:
if PIXEL_CACHE[chid]['hash'] == current_pixel_hash:
for ipix, pix in enumerate(data.pixel_component_ids):
if (
ipix not in matching_pixel_cache and
ipix in PIXEL_CACHE[chid] and
PIXEL_CACHE[chid][ipix]['bounds'] == bounds
):
matching_pixel_cache[ipix] = PIXEL_CACHE[chid][ipix] |
dhomeier
reviewed
Mar 19, 2025
Collaborator
I can only agree ;-) |
Co-authored-by: Derek Homeier <dhomeie@gwdg.de>
dhomeier
reviewed
Mar 19, 2025
| # still use cache_id because we still want to make sure we save results from different layers | ||
| # to the cache in case any layers get removed or changed. | ||
| matching_pixel_cache = {} | ||
| for chid, i_cache in PIXEL_CACHE.items(): |
Collaborator
There was a problem hiding this comment.
actually I am surprised Ruff does not complain now that chid is never used – or suggested to use PIXEL_CACHE.values() in the first place... 😂
Member
Author
There was a problem hiding this comment.
Oh yeah, we should fix that, we should just use .values()...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, but can already be tested out.