Remove multiline comments with compress option

[zakjan]

Currently multiline comments are not removed because . doesn't match \n.

s regex modifier is required for . to match \n.

[zakjan]

Upstream PR vwochnik/rollup-plugin-glsl#7

[pschroen]

Hi, the compress option should already remove multiline comments without the s regex modifier, as it already handles \r and \n in the expression.

For example, the test case uses glsl-noise/simplex/3d by checking if // Description from the 2nd line is removed or not.

Would you be able to provide the multiline comment that isn't being removed we could test against?

[zakjan]

By multiline comment I mean /* ...\n... */, such comment is not removed.

[pschroen]

Ah, I see, let's add a test case for that. Is there a glslify module you're using that isn't compressing, or your own comment?

[zakjan]

It's custom GLSL code.

[pschroen]

Alright, also getting a linting error:

13:26 error Parsing error: Invalid regular expression flag

Investigating...

[pschroen]

It appears as though the s regex modifier is new to ES2018, it works, just need to update the ESLint config.

I'll merge the PR and update the ESLint config.

[pschroen]

Published rollup-plugin-glslify@1.2.1. If you can confirm your multiline comments are being removed now. Thanks!

[zakjan]

Yes, it works, thanks!