Skip to content

Conversation

@cconard96
Copy link
Contributor

@cconard96 cconard96 commented Jan 1, 2026

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

  • Drop some IE support which has not been a supported browser for GLPI since 9.5.
  • Drop use of Pragma header which has been replaced by Cache-Control. Pragma only has use in systems that do not support the HTTP/1.1 standard which was released in 1997.
  • Remove -webkit-box-shadow and -moz-box-shadow in favor of box-shadow as it is part of the CSS baseline since 2015.
  • Remove -webkit-appearance in favor of appearance as it is part of the CSS baseline since 2022.
  • Remove all -ms-* CSS properties as they are for IE and pre-Chromium Edge browsers which have not been supported by GLPI for several years.
  • Remove -moz-user-select in favor of user-select as it has been supported by Firefox since late 2019. The -webkit-user-select property was left in place as Safari still does not support the standard version.
  • Remove -*-linear-gradient() in favor of linear-gradient() as it is part of the CSS baseline since 2022.

@trasher
Copy link
Contributor

trasher commented Jan 5, 2026

Seems OK to me, I guess it could target 11.0/bugfixes

$theme = ThemeManager::getInstance()->getTheme($_GET['key']);
$preview = $theme?->getPreviewPath(false);

header_remove('Pragma');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that PHP automatically sends this header when a session is started. This should be double checked.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess all header_remove could be kept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that and thought the comments were old and referring to something GLPI did when it started the session. Indeed the default cache limiter for sessions is "nocache" and this specific strategy sends the Pragma header.

However, if the Cache-Control header is present, all modern systems should use that and ignore any Pragma header.

@cconard96 cconard96 force-pushed the task/drop_ie_compat branch from 63d0ed9 to 1f13e8e Compare January 6, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants