Feat add pictures to models

[Lainow]

Checklist before requesting a review

Please delete options that are not relevant.

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.
• I have added tests that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• It fixes !39739
• Here is a brief description of what this PR does

Screenshots (if appropriate):

On the model page

On the device page when a model is linked

[AdrienClairembault]

Ok for me besides the unrelated illustration field being deleted 👍

Also, is "Rack pictures" the correct label here? This doesn't seem related to racks.

[stonebuzz]

After adding the model’s rear and front images, it is no longer possible to add an image (and vice versa).

When adding a rear or front image here…

It is no longer possible to add additional images.

Another point :
Deleting a single image does not work (deleting both at the same time works).

[stonebuzz]

@Lainow,

To maintain consistency with other models that include images, we need to keep the "Other Pictures" field.

Example for computer models:

Example for graphics card models (implementation in progress):

Another point:

When uploading images while adding a graphics card model, some images are not displayed correctly or missing entirely.

Here are the relevant PHP logs from GLPI:

[2026-01-05 13:07:12] glpi.INFO:   *** Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated at Toolbox.php line 591
  Backtrace :
  ./src/Toolbox.php:591                              
  ./front/document.send.php:115                      Toolbox::getFileAsResponse()
  ...Glpi/Controller/LegacyFileLoadController.php:64 require()
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\LegacyFileLoadController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:197        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:70                              Symfony\Component\HttpKernel\Kernel->handle()

[2026-01-05 13:07:12] glpi.INFO:   *** Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated at Toolbox.php line 597
  Backtrace :
  ./src/Toolbox.php:597                              
  ./front/document.send.php:115                      Toolbox::getFileAsResponse()
  ...Glpi/Controller/LegacyFileLoadController.php:64 require()
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\LegacyFileLoadController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:197        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:70                              Symfony\Component\HttpKernel\Kernel->handle()

[2026-01-05 13:07:12] glpi.WARNING:   *** User Warning: Unexpected output detected in `./front/document.send.php`. at LegacyFileLoadController.php line 80
  Backtrace :
  ...Glpi/Controller/LegacyFileLoadController.php:80 
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\LegacyFileLoadController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:197        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:70                              Symfony\Component\HttpKernel\Kernel->handle()

Tested with

[Lainow]

When uploading images while adding a graphics card model, some images are not displayed correctly or missing entirely.

Here are the relevant PHP logs from GLPI:

[2026-01-05 13:07:12] glpi.INFO:   *** Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated at Toolbox.php line 591
  Backtrace :
  ./src/Toolbox.php:591                              
  ./front/document.send.php:115                      Toolbox::getFileAsResponse()
  ...Glpi/Controller/LegacyFileLoadController.php:64 require()
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\LegacyFileLoadController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:197        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:70                              Symfony\Component\HttpKernel\Kernel->handle()

[2026-01-05 13:07:12] glpi.INFO:   *** Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated at Toolbox.php line 597
  Backtrace :
  ./src/Toolbox.php:597                              
  ./front/document.send.php:115                      Toolbox::getFileAsResponse()
  ...Glpi/Controller/LegacyFileLoadController.php:64 require()
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\LegacyFileLoadController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:197        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:70                              Symfony\Component\HttpKernel\Kernel->handle()

[2026-01-05 13:07:12] glpi.WARNING:   *** User Warning: Unexpected output detected in `./front/document.send.php`. at LegacyFileLoadController.php line 80
  Backtrace :
  ...Glpi/Controller/LegacyFileLoadController.php:80 
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\LegacyFileLoadController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:197        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:70                              Symfony\Component\HttpKernel\Kernel->handle()

I tested it with the images you gave me, but I don't have any problems. I also tried it with other images and had no problems.

[stonebuzz]

Perhaps the image on my machine is causing the issue (here it was uploaded via GitHub).