-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Enhancement / Add button to expand/collapse notes on notepad component #22427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11.0/bugfixes
Are you sure you want to change the base?
Enhancement / Add button to expand/collapse notes on notepad component #22427
Conversation
| } %} | ||
|
|
||
| <div class="firstbloc"> | ||
| <div class="firstbloc d-flex gap-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will certainly cause an issue with changes from #22404
|
@stonebuzz as we discussed in the meeting :
|
|
@Mary-Clb, would it be possible to add an icon (e.g. |
|
One last point: When clicking on a single note, its opening behavior differs from using the "View All" button. Manually, opening a note takes about one second, whereas opening it via the link is instantaneous. Ideally, bulk opening should occur at the same speed as opening notes manually. |
js/common.js
Outdated
| * | ||
| * @param {Element} element - The element that was clicked (button or link) | ||
| */ | ||
| window.toggleNotesAccordion = function(element) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While inline script blocks are not ideal, keeping this code in the notepad form template will make it easier to know it is only used for the notepad form when JS gets reorganized into "components" or modules in the future.
|
Please rebase to solve conflicts |
2104b1c to
3be0127
Compare
| data-expand-title="{{ __('Show all') }}" | ||
| data-collapse-title="{{ __('Expand all') }}"> | ||
| <i class="ti ti-eye-off"></i> | ||
| <span>{{ __('Show all') }}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cedric-anne
I'm having trouble with the translations for the expand/collapse functionality:
- When I use "collapse all", it remains in English
- When I use "show all", it translates to "voir tous" instead of the expected "voir tout"
Could you help clarify which translation keys I should use ?


Description
It fixes !41065
The issue was initially reported for project notes.
However, the fix has been implemented at the
Notepadclass level by adding a toggle button, allowing notes to be collapsed and expanded across all components that use notes.