Management of duplicate documents during entity transfer #22389
+219
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please add tests. Similar errors also happen on other itemtypes; see #20256 (documents and softwareversion so far). Fix is maybe the same. |
trasher
reviewed
Dec 18, 2025
tests/functional/TransferTest.php
Outdated
| ]); | ||
| $this->assertGreaterThan(0, $ticket_source_id); | ||
|
|
||
| // Link the SAME document to the source ticket |
Contributor
There was a problem hiding this comment.
I guess that was what I missed when I take a look at similar issue ^^
trasher
approved these changes
Dec 18, 2025
Rom1-B
suggested changes
Dec 18, 2025
stonebuzz
suggested changes
Dec 19, 2025
Rom1-B
suggested changes
Dec 19, 2025
Contributor
There was a problem hiding this comment.
The tests do not seem to execute the code you modified.
Contributor
|
@AdrienClairembault, the E2E tests that are failing do not seem to be related to this PR. Could you please confirm? |
Contributor
Yes, I confirm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
When transferring a ticket to another entity, if a document is already linked to the same object in the destination entity, a SQL duplicate error occurs.
This error is caused by the unique constraint on the glpi_documents_items table, applied to the columns (documents_id, itemtype, items_id, timeline_position).
Modification of the transferDocuments method in Transfer.php.
Before each UPDATE: check whether the target relationship already exists :
Before each INSERT: check whether the relationship already exists :