-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Use GLPI api in e2e tests #22371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GLPI api in e2e tests #22371
Conversation
package.json
Outdated
| "@typescript-eslint/parser": "^8.49.0", | ||
| "altcha": "^2.1.0", | ||
| "animate.css": "^4.1.1", | ||
| "axios": "^1.13.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in devDependencies, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be used in non-test code eventually to replace jQuery AJAX (#22353). I actually just noticed I put axios in my PR in the devDependencies by mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw in your PR it's used in non dev, yes... I can stay there is #22353 is approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I've ran npm install --dev axios instead of npm install --save-dev (it's a pain that npm and composer use different args for this, I always get them mixed up...).
I'll move it to dev for this one, #22353 is another subject so it shouldn't depend on this (and I think we have a rule against adding new dependencies in a bugfix releases as it complicate things for package manager if I recall correctly?).
dfc5c27 to
9c54a9e
Compare
|
(Rebased) |
* Add E2E environment (#21802) * Install and run playwright (#22028) * Use .dotenv for playwright configuratio (#22097) * Add CI configuration for playwright (#22103) * Logged in tests (#22121) * Lint playwright tests (#22323) * Use jq to compute playwright version (#22339) * Switch profiles in playwright's tests (#22344) * Avoid creating root file for playwright (#22380) * Use GLPI api in e2e tests (#22371) * Fix race condition when creating illustrations directory * Silence warnings from mkdir * Fail playwright step if errors are found in the logs (#22409) * Migrate tests to playwright (1) * Explain how to write e2e tests in the README (#22425)
No description provided.