Skip to content

Conversation

@AdrienClairembault
Copy link
Contributor

No description provided.

package.json Outdated
"@typescript-eslint/parser": "^8.49.0",
"altcha": "^2.1.0",
"animate.css": "^4.1.1",
"axios": "^1.13.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in devDependencies, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be used in non-test code eventually to replace jQuery AJAX (#22353). I actually just noticed I put axios in my PR in the devDependencies by mistake.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw in your PR it's used in non dev, yes... I can stay there is #22353 is approved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I've ran npm install --dev axios instead of npm install --save-dev (it's a pain that npm and composer use different args for this, I always get them mixed up...).

I'll move it to dev for this one, #22353 is another subject so it shouldn't depend on this (and I think we have a rule against adding new dependencies in a bugfix releases as it complicate things for package manager if I recall correctly?).

@AdrienClairembault
Copy link
Contributor Author

(Rebased)

@cedric-anne cedric-anne merged commit 553d153 into glpi-project:task/playwright Dec 16, 2025
9 checks passed
@AdrienClairembault AdrienClairembault deleted the e2e-to-api branch December 16, 2025 14:45
cedric-anne pushed a commit that referenced this pull request Dec 18, 2025
AdrienClairembault added a commit that referenced this pull request Dec 18, 2025
cedric-anne added a commit that referenced this pull request Dec 18, 2025
* Add E2E environment (#21802)
* Install and run playwright (#22028)
* Use .dotenv for playwright configuratio (#22097)
* Add CI configuration for playwright (#22103)
* Logged in tests (#22121)
* Lint playwright tests (#22323)
* Use jq to compute playwright version (#22339)
* Switch profiles in playwright's tests (#22344)
* Avoid creating root file for playwright (#22380)
* Use GLPI api in e2e tests (#22371)
* Fix race condition when creating illustrations directory
* Silence warnings from mkdir
* Fail playwright step if errors are found in the logs (#22409)
* Migrate tests to playwright (1)
* Explain how to write e2e tests in the README (#22425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants