Skip to content

Conversation

@rosecers
Copy link

Without these args, on OSX Catalina (10.15.4) throws the error:

fsph/../src/spherical_harmonics.hpp:1:10: fatal error: 'iostream.h' file not found
#include <iostream>```

for many "includes" in multiple files. This fix is modeled after a solution from [this random issue discussion](https://github.com/wouterboomsma/eigency/issues/32) which fixed the problem.

@klarh
Copy link
Collaborator

klarh commented Oct 15, 2020

I know we've run into this issue on basically all the glotzerlab projects that end up compiling things at one point or another; I don't think unconditionally adding that flag is the right choice because that breaks compilation on linux, though. I think the little if-clause at https://github.com/glotzerlab/freud/blob/deef8b5678e10c1a8157e4b8e617f80aea2f1706/setup.py#L406 fixes this issue in freud; could you try just that change in setup.py and see if that fixes the problem?

@rosecers rosecers force-pushed the osx_compile_options branch from 55cdf41 to 392af80 Compare October 15, 2020 13:56
@rosecers
Copy link
Author

I know we've run into this issue on basically all the glotzerlab projects that end up compiling things at one point or another; I don't think unconditionally adding that flag is the right choice because that breaks compilation on linux, though. I think the little if-clause at https://github.com/glotzerlab/freud/blob/deef8b5678e10c1a8157e4b8e617f80aea2f1706/setup.py#L406 fixes this issue in freud; could you try just that change in setup.py and see if that fixes the problem?

It worked! I included the fix and rebased. CI running now.

@klarh klarh force-pushed the osx_compile_options branch from 392af80 to babf94f Compare October 15, 2020 14:00
@klarh
Copy link
Collaborator

klarh commented Oct 15, 2020

Some of the tests would fail because scipy wasn't installed; I rebased your commit to fix that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants