Add support for compressed WIF and Bitcoin adsress #1
Conversation
| @@ -1 +1,2 @@ | |||
| .idea No newline at end of file | |||
| .idea | |||
| encypted-private-keys No newline at end of file | |||
There was a problem hiding this comment.
Add encypted-private-keys to .gitignore
| compress := false | ||
| format := wallet.GetFormat(compress) | ||
| net := netchain.TestNet | ||
| wif, address, privateKey := wallet.New(net, compress) |
There was a problem hiding this comment.
You broke backward compatibility here, now my repos wallet.New won't compile. Can you create a new function wallet.NewWIF?
| return wif.String(), addr.EncodeAddress(), hex.EncodeToString(priv.Serialize()) | ||
| } | ||
|
|
||
| func GetWallet(hexPriv string, net netchain.Net, compress bool) (wifString string, bitcoinAddress string) { |
There was a problem hiding this comment.
It's basically converting privateKey to wif format comppresed/ uncompressed?
|
|
||
| func NewAddress(net netchain.Net) string { | ||
| _, address := New(net) | ||
| func GetBitcoinAddress(priv *btcec.PrivateKey, net netchain.Net, compress bool) *btcutil.AddressPubKey { |
There was a problem hiding this comment.
I don't want to expose an object from internal library, that one day I might replace. Again it's me worrying for backward compatibility in the future
| ) | ||
|
|
||
| func TestAddressFromPrivateKey(t *testing.T) { | ||
| address, err := AddressFromPrivateKey("932u6Q4xEC9UYRb3rS2BWrSpSPEt5KaU8NNP7EWy7zSkWmfBiGe", netchain.TestNet) |
There was a problem hiding this comment.
Keep the test unchanged, that will ensure backward compatibility:)
| "github.com/glossd/btc/netchain" | ||
| ) | ||
|
|
||
| func AddressFromPrivateKey(privKey string, net netchain.Net) (string, error) { |
There was a problem hiding this comment.
Yeah, we need to keep the function, just proxy it to AddressFromWif(privKey, net, false)
| return err == nil | ||
| } | ||
|
|
||
| func GetFormat(compress bool) string { |
2 participants
No description provided.